fix(e2e): harden Windows plugin assertions

2026-08-12 21:53:00 -06:00 · 2026-05-24 19:09:57 +02:00
parent 5f0315467b
commit 8edc671eb4
6 changed files with 226 additions and 139 deletions
@@ -0,0 +1,68 @@
+import { spawnSync } from "node:child_process";
+import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import path from "node:path";
+import { describe, expect, it } from "vitest";
+
+const ASSERTIONS_SCRIPT = "scripts/e2e/lib/plugins/assertions.mjs";
+
+function writeJson(filePath: string, value: unknown) {
+  mkdirSync(path.dirname(filePath), { recursive: true });
+  writeFileSync(filePath, `${JSON.stringify(value, null, 2)}\n`, "utf8");
+}
+
+describe("plugins Docker assertions", () => {
+  it("keeps sweep artifact paths aligned with the assertion scratch root", () => {
+    const scripts = [
+      "scripts/e2e/lib/plugins/sweep.sh",
+      "scripts/e2e/lib/plugins/marketplace.sh",
+      "scripts/e2e/lib/plugins/clawhub.sh",
+    ];
+
+    for (const scriptPath of scripts) {
+      const script = readFileSync(scriptPath, "utf8");
+      expect(script).toContain("OPENCLAW_PLUGINS_TMP_DIR");
+      expect(script).not.toMatch(
+        /\/tmp\/(?:plugins|marketplace|demo-plugin|is-number|openclaw-plugin|openclaw-clawhub)/,
+      );
+    }
+  });
+
+  it("uses the configured scratch root and resolves Windows home-relative install paths", () => {
+    const root = mkdtempSync(path.join(tmpdir(), "openclaw-plugins-assertions-"));
+    const home = path.join(root, "home");
+    const scratchRoot = path.join(root, "scratch");
+    const installPath = path.join(home, "managed-plugin");
+    mkdirSync(installPath, { recursive: true });
+
+    try {
+      writeJson(path.join(scratchRoot, "plugins2.json"), {
+        plugins: [{ id: "demo-plugin-tgz", status: "loaded" }],
+      });
+      writeJson(path.join(scratchRoot, "plugins2-inspect.json"), {
+        gatewayMethods: ["demo.tgz"],
+      });
+      writeJson(path.join(home, ".openclaw", "plugins", "installs.json"), {
+        installRecords: {
+          "demo-plugin-tgz": {
+            source: "archive",
+            installPath: String.raw`~\managed-plugin`,
+          },
+        },
+      });
+
+      const result = spawnSync(process.execPath, [ASSERTIONS_SCRIPT, "plugin-tgz"], {
+        encoding: "utf8",
+        env: {
+          ...process.env,
+          HOME: home,
+          OPENCLAW_PLUGINS_TMP_DIR: scratchRoot,
+        },
+      });
+
+      expect(result.status).toBe(0);
+    } finally {
+      rmSync(root, { force: true, recursive: true });
+    }
+  });
+});