diff --git a/.github/workflows/maturity-scorecard.yml b/.github/workflows/maturity-scorecard.yml index 7371f6464b27..6a10a29b0eb4 100644 --- a/.github/workflows/maturity-scorecard.yml +++ b/.github/workflows/maturity-scorecard.yml @@ -134,7 +134,7 @@ jobs: with: ref: ${{ inputs.ref }} expected_sha: ${{ needs.validate_selected_ref.outputs.selected_revision }} - qa_profile: release + qa_profile: all secrets: OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} @@ -238,8 +238,8 @@ jobs: } const evidence = JSON.parse(fs.readFileSync(evidencePath, "utf8")); - if (evidence.profile !== "release") { - throw new Error(`qa-evidence.json profile must be release, got ${JSON.stringify(evidence.profile)}`); + if (evidence.profile !== "all") { + throw new Error(`qa-evidence.json profile must be all, got ${JSON.stringify(evidence.profile)}`); } const artifactDir = path.dirname(evidencePath); @@ -256,8 +256,8 @@ jobs: const manifestPath = path.join(artifactDir, manifestNames[0]); const manifest = JSON.parse(fs.readFileSync(manifestPath, "utf8")); const manifestProfile = manifest.qaProfile ?? evidence.profile; - if (manifestProfile !== "release") { - throw new Error(`QA evidence manifest profile must be release, got ${JSON.stringify(manifestProfile)}`); + if (manifestProfile !== "all") { + throw new Error(`QA evidence manifest profile must be all, got ${JSON.stringify(manifestProfile)}`); } if (manifest.targetSha !== targetSha) { throw new Error(`QA evidence manifest targetSha ${manifest.targetSha} does not match selected ref ${targetSha}`); @@ -428,14 +428,14 @@ jobs: cat > "$body_file" < { expect(qaEvidenceWorkflow.on.workflow_dispatch.inputs).not.toHaveProperty("fail_on_qa_failure"); expect(qaEvidenceWorkflow.on.workflow_call.inputs).not.toHaveProperty("fail_on_qa_failure"); expect(qaEvidenceWorkflow.on.workflow_dispatch.inputs.qa_profile).not.toHaveProperty("options"); + expect(qaEvidenceWorkflow.on.workflow_dispatch.inputs.qa_profile.default).toBe("all"); expect(qaEvidenceWorkflow.on.workflow_call.inputs.qa_profile.type).toBe("string"); const validateProfileStep = qaRunJob.steps.find( (step) => step.name === "Validate QA profile input", @@ -682,7 +683,7 @@ describe("ci workflow guards", () => { // Keep the caller's ref while the callee verifies it against expected_sha. ref: "${{ inputs.ref }}", expected_sha: "${{ needs.validate_selected_ref.outputs.selected_revision }}", - qa_profile: "release", + qa_profile: "all", }); expect(generateJob.with).not.toHaveProperty("fail_on_qa_failure"); @@ -713,6 +714,8 @@ describe("ci workflow guards", () => { (step) => step.name === "Validate QA evidence manifest", ); expect(validateManifestStep.run).toContain("qa-profile-evidence-manifest.json"); + expect(validateManifestStep.run).toContain("qa-evidence.json profile must be all"); + expect(validateManifestStep.run).toContain("QA evidence manifest profile must be all"); expect(validateManifestStep.run).toContain("manifest.targetSha !== targetSha"); expect(qaRunJob.outputs.artifact_name).toBe("${{ steps.evidence.outputs.artifact_name }}");