From 807491e0f125fc16e7f1816229aed767c480c3bf Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sun, 12 Jul 2026 22:41:35 -0700 Subject: [PATCH] ci: consolidate SMS webhook test reset (#106070) * ci: clear stale dead-export surfaces * ci: align dead-export baseline --- extensions/sms/src/webhook.test.ts | 2 -- extensions/sms/src/webhook.ts | 7 ++----- scripts/deadcode-exports.baseline.mjs | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/extensions/sms/src/webhook.test.ts b/extensions/sms/src/webhook.test.ts index 28465ef165aa..6591f347958e 100644 --- a/extensions/sms/src/webhook.test.ts +++ b/extensions/sms/src/webhook.test.ts @@ -7,7 +7,6 @@ import { computeTwilioSignature, parseTwilioFormBody } from "./twilio.js"; import type { ResolvedSmsAccount } from "./types.js"; import { createSmsWebhookHandler, - resetSmsWebhookRateLimiterForTest, createSmsWebhookReplayGuard, resetSmsWebhookReplayGuardsForTest, } from "./webhook.js"; @@ -116,7 +115,6 @@ function createMessageSid(index: number): string { describe("createSmsWebhookHandler", () => { beforeEach(() => { dispatchSmsInboundEvent.mockClear(); - resetSmsWebhookRateLimiterForTest(); resetSmsWebhookReplayGuardsForTest(); }); diff --git a/extensions/sms/src/webhook.ts b/extensions/sms/src/webhook.ts index fadb672c11b9..2cfd94e0b7b4 100644 --- a/extensions/sms/src/webhook.ts +++ b/extensions/sms/src/webhook.ts @@ -104,6 +104,8 @@ function resolveSmsWebhookReplayGuard(account: ResolvedSmsAccount): SmsWebhookRe export function resetSmsWebhookReplayGuardsForTest(): void { replayGuardsByAccount.clear(); + invalidRequestRateLimiter.clear(); + callbackDispatchRateLimiter.clear(); } type SmsWebhookLog = { @@ -152,11 +154,6 @@ function rejectInvalidRequestRateLimit(params: { return true; } -export function resetSmsWebhookRateLimiterForTest(): void { - invalidRequestRateLimiter.clear(); - callbackDispatchRateLimiter.clear(); -} - // Each account route owns its guard so one saturated account cannot block sibling accounts. export function createSmsWebhookHandler( params: SmsWebhookHandlerParams, diff --git a/scripts/deadcode-exports.baseline.mjs b/scripts/deadcode-exports.baseline.mjs index e2ba15eea184..f4aa9f994e1e 100644 --- a/scripts/deadcode-exports.baseline.mjs +++ b/scripts/deadcode-exports.baseline.mjs @@ -1018,7 +1018,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "extensions/sms/src/twilio.ts: parseTwilioFormBody", "extensions/sms/src/twilio.ts: TwilioSmsApiError", "extensions/sms/src/webhook.ts: createSmsWebhookReplayGuard", - "extensions/sms/src/webhook.ts: resetSmsWebhookRateLimiterForTest", "extensions/sms/src/webhook.ts: resetSmsWebhookReplayGuardsForTest", "extensions/synology-chat/src/channel.ts: createSynologyChatPlugin", "extensions/synology-chat/src/channel.ts: synologyChatMessageAdapter",