ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-12 21:53:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): honor Periphery ignores in shared intersection (#110839)

Browse Source
This commit is contained in:
Peter Steinberger
2026-07-18 18:46:52 +01:00
committed by GitHub
parent 917bec3987
commit 7e27101f2c
3 changed files with 88 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/periphery-intersection.mjs
+40 -3
View File
@@ -5,6 +5,8 @@ import path from "node:path";
import { isDirectRunUrl } from "./lib/direct-run.mjs";
const SHARED_LOCATION_PREFIX = "../shared/OpenClawKit/Sources/";
const SHARED_SOURCE_ROOT = "apps/shared/OpenClawKit/Sources";
const BARE_PERIPHERY_IGNORE_COMMENT = /\/\/\/?\s*periphery:ignore(?![:\w])/;
function requireValue(args, index, option) {
const value = args[index + 1];
@@ -107,6 +109,39 @@ export function parseRepoLocation(location) {
};
}
export function filterIgnoredFindings(findings, repoRoot = process.cwd()) {
const sourceRoot = path.resolve(repoRoot, SHARED_SOURCE_ROOT);
const sourceLines = new Map();
return findings.filter((finding) => {
const location = parseRepoLocation(finding.location);
const sourceFile = path.resolve(repoRoot, location.file);
const relativeSource = path.relative(sourceRoot, sourceFile);
if (
!relativeSource ||
path.isAbsolute(relativeSource) ||
relativeSource === ".." ||
relativeSource.startsWith(`..${path.sep}`)
) {
throw new Error(`invalid shared Periphery source path: ${location.file}`);
}
let lines = sourceLines.get(sourceFile);
if (!lines) {
lines = fs.readFileSync(sourceFile, "utf8").split(/\r?\n/);
sourceLines.set(sourceFile, lines);
}
const declarationIndex = Number(location.line) - 1;
if (declarationIndex < 0 || declarationIndex >= lines.length) {
throw new Error(`invalid shared Periphery source line: ${finding.location}`);
}
return ![lines[declarationIndex - 1], lines[declarationIndex]].some(
(line) => typeof line === "string" && BARE_PERIPHERY_IGNORE_COMMENT.test(line),
);
});
}
export function escapeCommandData(value) {
return String(value ?? "")
.replaceAll("%", "%25")
@@ -166,9 +201,11 @@ export function run(args, env = process.env) {
const options = parseArgs(args);
readStatus(options.iosStatus, "iOS");
readStatus(options.macosStatus, "macOS");
const findings = intersectFindings(
readFindings(options.iosResults, "iOS"),
readFindings(options.macosResults, "macOS"),
const findings = filterIgnoredFindings(
intersectFindings(
readFindings(options.iosResults, "iOS"),
readFindings(options.macosResults, "macOS"),
),
);
fs.mkdirSync(path.dirname(options.output), { recursive: true });