ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-24 11:25:50 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugins): surface actionable doctor warnings (#117357)

Browse Source 
Co-authored-by: Peter Steinberger <steipete@macos.shared>
This commit is contained in:
Peter Steinberger
2026-08-01 04:51:43 -07:00
committed by GitHub
parent 2d545c16c3
commit 7bd7d7d2a1
2 changed files with 50 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cli/plugins-cli.list.test.ts
+49
View File
@@ -100,6 +100,55 @@ describe("plugins cli list", () => {
expect(runtimeLogs).toContain(cleanDoctorMessage);
});
it.each([
{
description: "a required plugin is missing",
diagnostic: {
level: "warn" as const,
pluginId: "calendar",
message: 'plugin "calendar" requires plugin "contacts"; install "contacts" to use it',
},
expected: 'calendar: plugin "calendar" requires plugin "contacts"',
},
{
description: "discovery cannot read an extensions directory",
diagnostic: {
level: "warn" as const,
message: "failed to read extensions dir: /tmp/plugins (permission denied)",
},
expected: "failed to read extensions dir: /tmp/plugins (permission denied)",
},
])(
"reports actionable discovery warnings when $description",
async ({ diagnostic, expected }) => {
buildPluginDiagnosticsReport.mockReturnValue({ plugins: [], diagnostics: [diagnostic] });
await runPluginsCommand(["plugins", "doctor"]);
const output = runtimeLogs.join("\n");
expect(output).toContain("Diagnostics:");
expect(output).toContain(expected);
expect(output).not.toContain(cleanDoctorMessage);
},
);
it("keeps actionable discovery warnings alongside existing errors", async () => {
buildPluginDiagnosticsReport.mockReturnValue({
plugins: [],
diagnostics: [
{ level: "error", pluginId: "broken", message: "plugin manifest invalid" },
{ level: "warn", pluginId: "calendar", message: "required plugin contacts is missing" },
],
});
await runPluginsCommand(["plugins", "doctor"]);
const output = runtimeLogs.join("\n");
expect(output).toContain("broken: plugin manifest invalid");
expect(output).toContain("calendar: required plugin contacts is missing");
expect(output).not.toContain(cleanDoctorMessage);
});
it("reports stale plugin config in doctor output without claiming full plugin health", async () => {
const sourceConfig = {
plugins: {