From 79ac476b0f70536078363dba03dc7f13aacc2e67 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Wed, 12 Aug 2026 04:45:15 -0700 Subject: [PATCH] fix(test): type CDP DNS lookup mocks (#122607) Amp-Thread-ID: https://ampcode.com/threads/T-019ff3db-c467-70ad-8ed3-81f2ba94b0c0 Co-authored-by: Amp --- extensions/browser/src/browser/cdp.helpers.test.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/extensions/browser/src/browser/cdp.helpers.test.ts b/extensions/browser/src/browser/cdp.helpers.test.ts index ebd2401951ec..1535f8ae0f34 100644 --- a/extensions/browser/src/browser/cdp.helpers.test.ts +++ b/extensions/browser/src/browser/cdp.helpers.test.ts @@ -1,6 +1,7 @@ // Browser tests cover cdp.helpers plugin behavior. import { MAX_TIMER_TIMEOUT_MS } from "openclaw/plugin-sdk/number-runtime"; import { afterEach, describe, expect, it, vi } from "vitest"; +import type { LookupFn } from "../infra/net/ssrf.js"; import { assertChromeMcpCdpTransportAllowed, resolveCdpReachabilityPolicy, @@ -13,6 +14,11 @@ const PROFILE_HTTP_REACHABILITY_TIMEOUT_MS = 300; const PROFILE_WS_REACHABILITY_MIN_TIMEOUT_MS = 200; const PROFILE_WS_REACHABILITY_MAX_TIMEOUT_MS = 2000; +function createLookupFn(address: string): LookupFn { + const family = address.includes(":") ? 6 : 4; + return vi.fn(async () => [{ address, family }]) as unknown as LookupFn; +} + const fetchWithSsrFGuardMock = vi.hoisted(() => vi.fn()); vi.mock("openclaw/plugin-sdk/ssrf-runtime", async (importOriginal) => { @@ -167,7 +173,7 @@ describe("cdp helpers", () => { await expect( resolvePinnedHostnameWithPolicy("browser.example", { policy: scoped, - lookupFn: async () => [{ address: "10.0.0.8", family: 4 }], + lookupFn: createLookupFn("10.0.0.8"), }), ).rejects.toThrow(/private\/internal\/special-use ip address/i); }); @@ -188,7 +194,7 @@ describe("cdp helpers", () => { await expect( resolvePinnedHostnameWithPolicy("browser.example", { policy: scoped, - lookupFn: async () => [{ address: "10.0.0.8", family: 4 }], + lookupFn: createLookupFn("10.0.0.8"), }), ).resolves.toEqual(expect.objectContaining({ addresses: ["10.0.0.8"] })); });