ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-12 21:53:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): force-kill plugin fixture servers

Browse Source
This commit is contained in:
Vincent Koc
2026-06-18 02:42:46 +02:00
parent 622b67067e
commit 7430079cd7
2 changed files with 97 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/scripts/plugins-assertions.test.ts
+63
View File
@@ -79,6 +79,24 @@ function writeFixtureServerShims(binDir: string, pidPath: string): void {
writeFileSync(pidPath, "");
}
function writeStubbornFixtureServerShims(binDir: string, pidPath: string): void {
mkdirSync(binDir, { recursive: true });
writeFileSync(
path.join(binDir, "node"),
[
"#!/bin/bash",
'printf "%s\\n" "$$" >"$OPENCLAW_TEST_FIXTURE_SERVER_PID"',
"trap ':' TERM",
"while true; do /bin/sleep 1; done",
"",
].join("\n"),
);
writeFileSync(path.join(binDir, "sleep"), "#!/bin/bash\nexit 0\n");
chmodSync(path.join(binDir, "node"), 0o755);
chmodSync(path.join(binDir, "sleep"), 0o755);
writeFileSync(pidPath, "");
}
function writeCrashingFixtureServerShim(binDir: string): void {
mkdirSync(binDir, { recursive: true });
writeFileSync(
@@ -327,6 +345,51 @@ test -d "$OPENCLAW_PLUGINS_TMP_DIR"
}
});
it("force-kills stubborn npm fixture registry children during cleanup", () => {
const root = mkdtempSync(path.join(tmpdir(), "openclaw-plugin-npm-fixture-kill-"));
try {
const binDir = path.join(root, "bin");
const fixtureDir = path.join(root, "fixture");
const pidPath = path.join(root, "server.pid");
mkdirSync(fixtureDir);
writeStubbornFixtureServerShims(binDir, pidPath);
const result = spawnSync(
"/bin/bash",
[
"-c",
[
"set -euo pipefail",
"source scripts/e2e/lib/plugins/fixtures.sh",
"set +e",
`( start_npm_fixture_registry fixture-pkg 1.0.0 ${shellQuote(path.join(root, "fixture.tgz"))} ${shellQuote(fixtureDir)} )`,
'status="$?"',
"set -e",
'[ "$status" != "0" ]',
].join("\n"),
],
{
cwd: process.cwd(),
encoding: "utf8",
env: {
...process.env,
OPENCLAW_PLUGINS_FIXTURE_STOP_ATTEMPTS: "2",
OPENCLAW_PLUGINS_FIXTURE_STOP_INTERVAL_SECONDS: "0.05",
OPENCLAW_TEST_FIXTURE_SERVER_PID: pidPath,
PATH: `${binDir}${path.delimiter}/usr/bin${path.delimiter}/bin`,
},
},
);
expect(result.status, result.stderr || result.stdout).toBe(0);
const pid = Number(readFileSync(pidPath, "utf8"));
expect(Number.isInteger(pid)).toBe(true);
waitForDead(pid);
} finally {
rmSync(root, { force: true, recursive: true });
}
});
it("bounds npm fixture registry logs when readiness fails", () => {
const root = mkdtempSync(path.join(tmpdir(), "openclaw-plugin-npm-fixture-log-"));
try {