ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-28 05:16:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): privatize new internal helpers (#107096)

Browse Source
This commit is contained in:
Vincent Koc
2026-07-14 12:02:46 +08:00
committed by GitHub
parent ea33260491
commit 63c7c21bdf
3 changed files with 48 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/daemon/service-env.test.ts
+18 -35
View File
@@ -3,10 +3,7 @@ import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { describe, expect, it, vi } from "vitest";
import {
isNodeVersionManagerRuntime,
resolveLinuxSystemCaBundle,
} from "../bootstrap/node-extra-ca-certs.js";
import { resolveAutoNodeExtraCaCerts } from "../bootstrap/node-extra-ca-certs.js";
import { resolveGatewayStateDir } from "./paths.js";
import {
buildNodeServiceEnvironment,
@@ -925,31 +922,6 @@ describe("resolveGatewayStateDir", () => {
});
});
describe("isNodeVersionManagerRuntime", () => {
it("returns true when NVM_DIR env var is set", () => {
expect(isNodeVersionManagerRuntime({ NVM_DIR: "/home/user/.nvm" })).toBe(true);
});
it("returns true when execPath contains /.nvm/", () => {
expect(isNodeVersionManagerRuntime({}, "/home/user/.nvm/versions/node/v22.22.0/bin/node")).toBe(
true,
);
});
it("returns false when neither NVM_DIR nor nvm execPath", () => {
expect(isNodeVersionManagerRuntime({}, "/usr/bin/node")).toBe(false);
});
});
describe("resolveLinuxSystemCaBundle", () => {
it("returns a known CA bundle path when one exists", () => {
const result = resolveLinuxSystemCaBundle();
if (process.platform === "linux") {
expect(result).toMatch(/\.(crt|pem)$/);
}
});
});
describe("shared Node TLS env defaults focused", () => {
it("sets macOS TLS defaults for gateway services", () => {
const env = buildServiceEnvironment({
@@ -971,9 +943,14 @@ describe("shared Node TLS env defaults focused", () => {
});
it("defaults NODE_EXTRA_CA_CERTS on Linux when NVM_DIR is set", () => {
const expected = resolveLinuxSystemCaBundle({ platform: "linux" });
const sourceEnv = { HOME: "/home/user", NVM_DIR: "/home/user/.nvm" };
const expected = resolveAutoNodeExtraCaCerts({
env: sourceEnv,
platform: "linux",
execPath: "/usr/bin/node",
});
const env = buildServiceEnvironment({
env: { HOME: "/home/user", NVM_DIR: "/home/user/.nvm" },
env: sourceEnv,
port: 18789,
platform: "linux",
execPath: "/usr/bin/node",
@@ -982,11 +959,17 @@ describe("shared Node TLS env defaults focused", () => {
});
it("defaults NODE_EXTRA_CA_CERTS on Linux when execPath is under nvm", () => {
const expected = resolveLinuxSystemCaBundle({ platform: "linux" });
const env = buildNodeServiceEnvironment({
env: { HOME: "/home/user" },
const sourceEnv = { HOME: "/home/user" };
const execPath = "/home/user/.nvm/versions/node/v22.22.0/bin/node";
const expected = resolveAutoNodeExtraCaCerts({
env: sourceEnv,
platform: "linux",
execPath: "/home/user/.nvm/versions/node/v22.22.0/bin/node",
execPath,
});
const env = buildNodeServiceEnvironment({
env: sourceEnv,
platform: "linux",
execPath,
});
expect(env.NODE_EXTRA_CA_CERTS).toBe(expected);
});