From 3706047d607702b0a19c1e8d50053c5f2f9bb9fd Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sat, 20 Jun 2026 03:58:42 +0800 Subject: [PATCH] refactor(core): drop unused internal helpers --- src/acp/control-plane/session-actor-queue.ts | 4 -- .../media-generate-tool-actions-shared.ts | 37 +------------------ src/cli/root-help-metadata.ts | 11 ------ src/transcripts/store.ts | 20 ---------- src/tui/components/chat-log.ts | 8 ---- 5 files changed, 1 insertion(+), 79 deletions(-) diff --git a/src/acp/control-plane/session-actor-queue.ts b/src/acp/control-plane/session-actor-queue.ts index a5c2a6398a41..1dc495e42b94 100644 --- a/src/acp/control-plane/session-actor-queue.ts +++ b/src/acp/control-plane/session-actor-queue.ts @@ -18,10 +18,6 @@ export class SessionActorQueue { return total; } - getPendingCountForSession(actorKey: string): number { - return this.pendingBySession.get(actorKey) ?? 0; - } - async run(actorKey: string, op: () => Promise): Promise { return this.queue.enqueue(actorKey, op, { onEnqueue: () => { diff --git a/src/agents/tools/media-generate-tool-actions-shared.ts b/src/agents/tools/media-generate-tool-actions-shared.ts index 72a73e567ed1..b96da7b1754f 100644 --- a/src/agents/tools/media-generate-tool-actions-shared.ts +++ b/src/agents/tools/media-generate-tool-actions-shared.ts @@ -123,7 +123,7 @@ export function createMediaGenerateProviderListActionResult< }; } -/** Creates status and duplicate-guard action helpers for a media generation task type. */ +/** Creates status action helpers for a media generation task type. */ export function createMediaGenerateTaskStatusActions(params: { inactiveText: string; findActiveTask: (sessionKey?: string) => Task | undefined; @@ -140,15 +140,6 @@ export function createMediaGenerateTaskStatusActions(params: { buildStatusDetails: params.buildStatusDetails, }); }, - - createDuplicateGuardResult(sessionKey?: string): MediaGenerateActionResult | undefined { - return createMediaGenerateDuplicateGuardResult({ - sessionKey, - findActiveTask: params.findActiveTask, - buildStatusText: params.buildStatusText, - buildStatusDetails: params.buildStatusDetails, - }); - }, }; } @@ -177,29 +168,3 @@ function createMediaGenerateStatusActionResult(params: { }, }; } - -function createMediaGenerateDuplicateGuardResult(params: { - sessionKey?: string; - findActiveTask: (sessionKey?: string) => Task | undefined; - buildStatusText: TaskStatusTextBuilder; - buildStatusDetails: (task: Task) => Record; -}): MediaGenerateActionResult | undefined { - const activeTask = params.findActiveTask(params.sessionKey); - if (!activeTask) { - return undefined; - } - // Duplicate guard returns the active status payload so callers can show current progress. - return { - content: [ - { - type: "text", - text: params.buildStatusText(activeTask, { duplicateGuard: true }), - }, - ], - details: { - action: "status", - duplicateGuard: true, - ...params.buildStatusDetails(activeTask), - }, - }; -} diff --git a/src/cli/root-help-metadata.ts b/src/cli/root-help-metadata.ts index dcc5074ab585..0a4c279cf874 100644 --- a/src/cli/root-help-metadata.ts +++ b/src/cli/root-help-metadata.ts @@ -162,14 +162,3 @@ function setPrecomputedSubcommandHelpText( [commandName]: value, }; } - -export const testing = { - resetPrecomputedRootHelpTextForTests(): void { - precomputedRootHelpText = undefined; - precomputedBrowserHelpText = undefined; - precomputedSecretsHelpText = undefined; - precomputedNodesHelpText = undefined; - precomputedSubcommandHelpText = undefined; - }, -}; -export { testing as __testing }; diff --git a/src/transcripts/store.ts b/src/transcripts/store.ts index 4cbd1610257a..46503270ee43 100644 --- a/src/transcripts/store.ts +++ b/src/transcripts/store.ts @@ -150,14 +150,6 @@ export class TranscriptsStore { return session ? { session, sessionDir: dir } : undefined; } - /** Append an utterance by session id, creating a dated session directory if needed. */ - async appendUtterance(sessionId: string, utterance: TranscriptUtterance): Promise { - const dir = - (await this.findSessionDir(sessionId)) ?? - path.join(this.rootDir, dateSegment(sessionId), safeSegment(sessionId)); - await this.appendUtteranceToDir(dir, sessionId, utterance); - } - /** Append an utterance for an exact session descriptor. */ async appendUtteranceForSession( session: TranscriptSessionDescriptor, @@ -195,18 +187,6 @@ export class TranscriptsStore { return await this.readUtterancesFromDir(sessionDir, options); } - /** Read utterances by session id or qualified date/id selector. */ - async readUtterances( - sessionId: string, - options: { maxUtterances?: number } = {}, - ): Promise { - const dir = await this.findSessionDir(sessionId); - if (!dir) { - return []; - } - return await this.readUtterancesFromDir(dir, options); - } - private async readUtterancesFromDir( dir: string, options: { maxUtterances?: number } = {}, diff --git a/src/tui/components/chat-log.ts b/src/tui/components/chat-log.ts index 3ddbafce21a3..5b4ffef329ab 100644 --- a/src/tui/components/chat-log.ts +++ b/src/tui/components/chat-log.ts @@ -363,14 +363,6 @@ export class ChatLog extends Container { return component; } - updateToolArgs(toolCallId: string, args: unknown) { - const existing = this.toolById.get(toolCallId); - if (!existing) { - return; - } - existing.setArgs(args); - } - updateToolResult( toolCallId: string, result: unknown,