From 295f2c0212fd759fabd5e80cecfd00fc324bb441 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 14 Aug 2026 20:42:37 -0700 Subject: [PATCH] fix(ui): align the sidebar to a shared grid and dedupe owner presence (#123938) * test(ui): add sidebar alignment capture harness * fix(ui): align sidebar rows to shared grid * fix(ui): distinguish sidebar owner presence * fix(ui): visually hide sidebar pages label * fix(ui): collapse the hidden pages head row * fix(ui): keep the floating pages action clickable * fix(ui): scope facepile dedup to the rendered lead and reveal the pages editor on touch ClawSweeper P1s on #123938: the facepile unconditionally excluded the session creator even when the lead chip showed the archivist or nothing at all, hiding a live viewer; renderSessionLeadingState now returns the rendered owner identity as the single dedup source. The hover-revealed pages editor gains the standard hoverless-pointer visibility override. --- ui/src/components/app-sidebar-render.ts | 2 +- .../app-sidebar-session-catalog-render.ts | 4 + .../app-sidebar-session-row-render.ts | 47 +++--- .../components/session-leading-indicator.ts | 15 +- ui/src/components/session-owner-chip.ts | 24 +-- ui/src/components/viewer-facepile.test.ts | 33 ++++ ui/src/components/viewer-facepile.ts | 9 +- .../e2e/sidebar-alignment.capture.e2e.test.ts | 149 ++++++++++++++++++ ui/src/i18n/locales/en.ts | 1 + ui/src/styles/components.css | 31 +++- ui/src/styles/layout.css | 87 ++++++---- ui/src/styles/layout.mobile.css | 2 +- .../catalog-project-activity.ts | 8 +- .../app-sidebar-cases/session-indicators.ts | 18 ++- .../app-sidebar-cases/session-ownership.ts | 21 +++ .../app-sidebar-cases/sessions.ts | 4 +- .../app-sidebar-cases/sidebar-zone.ts | 5 +- .../app-sidebar-cases/transient-menus.ts | 5 + 18 files changed, 374 insertions(+), 91 deletions(-) create mode 100644 ui/src/e2e/sidebar-alignment.capture.e2e.test.ts diff --git a/ui/src/components/app-sidebar-render.ts b/ui/src/components/app-sidebar-render.ts index 30fc1473bb55..47538ccc9769 100644 --- a/ui/src/components/app-sidebar-render.ts +++ b/ui/src/components/app-sidebar-render.ts @@ -227,7 +227,7 @@ export function renderAppSidebarHomeRow(host: AppSidebarRenderHost) { export function renderAppSidebarPagesHead(host: AppSidebarRenderHost) { return html`