diff --git a/scripts/check-changed.mjs b/scripts/check-changed.mjs index d91003ef3ab9..703cbe385c88 100644 --- a/scripts/check-changed.mjs +++ b/scripts/check-changed.mjs @@ -67,9 +67,7 @@ export function shouldSkipAppLintForMissingSwiftlint(options = {}) { const env = options.env ?? process.env; const platform = options.platform ?? process.platform; const swiftlintAvailable = options.swiftlintAvailable ?? executableExistsOnPath("swiftlint", env); - return ( - isTruthyEnvFlag(env.OPENCLAW_TESTBOX_REMOTE_RUN) && platform !== "darwin" && !swiftlintAvailable - ); + return platform !== "darwin" && !swiftlintAvailable; } export function shouldDelegateChangedCheckToCrabbox(argv = [], env = process.env) { @@ -231,11 +229,11 @@ export function createChangedCheckPlan(result, options = {}) { } if (lanes.apps && shouldSkipAppLintForMissingSwiftlint({ ...options, env: baseEnv })) { addCommand( - "lint apps (swiftlint unavailable in Testbox)", + "lint apps (swiftlint unavailable on this host)", "node", [ "-e", - "console.error('[check:changed] Swift app lint skipped: swiftlint is unavailable in this Linux Testbox; macOS CI owns SwiftLint coverage.')", + "console.error('[check:changed] Swift app lint skipped: swiftlint is unavailable on this non-macOS host; macOS CI owns SwiftLint coverage.')", ], baseEnv, ); diff --git a/test/scripts/changed-lanes.test.ts b/test/scripts/changed-lanes.test.ts index 8eab0f5c7327..84d21d001a73 100644 --- a/test/scripts/changed-lanes.test.ts +++ b/test/scripts/changed-lanes.test.ts @@ -865,12 +865,12 @@ describe("scripts/changed-lanes", () => { expect(plan.commands.map((command) => command.args[0])).not.toContain("tsgo:all"); }); - it("keeps app lint explicit when Linux Testbox lacks SwiftLint", () => { + it("keeps app lint explicit when non-macOS hosts lack SwiftLint", () => { const result = detectChangedLanes([ "apps/shared/OpenClawKit/Sources/OpenClawProtocol/GatewayModels.swift", ]); const plan = createChangedCheckPlan(result, { - env: { OPENCLAW_TESTBOX_REMOTE_RUN: "1", PATH: "/usr/bin" }, + env: { PATH: "/usr/bin" }, platform: "linux", swiftlintAvailable: false, }); @@ -881,7 +881,7 @@ describe("scripts/changed-lanes", () => { expect(plan.commands.map((command) => command.args[0])).not.toContain("lint:apps"); expect(plan.commands).toContainEqual( expect.objectContaining({ - name: "lint apps (swiftlint unavailable in Testbox)", + name: "lint apps (swiftlint unavailable on this host)", bin: "node", }), );