From 09eb2f9934dd58266dbb4d317c0fb66c899526fb Mon Sep 17 00:00:00 2001 From: "Vyctor H. Brzezowski" Date: Sun, 23 Aug 2026 14:19:23 -0300 Subject: [PATCH] improve(ui): even out transcript turn and run block spacing (#128298) * improve(ui): even out transcript turn and run block spacing * fix(ui): keep expanded tool rows compact * mock: fixtures (drop before land) * test(ui): lock transcript spacing rhythm * test(ui): cover expanded tool row spacing * test(ui): cover touch footer turn spacing * fix(ui): keep touch turn gaps stable with footer actions * fix(ui): preserve persistent footer turn spacing * fix(ui): preserve revealed footer turn spacing --- .../chat/chat-responsive.browser.test.ts | 131 ++++++++++++++++++ ui/src/styles/chat/grouped.css | 38 ++++- 2 files changed, 165 insertions(+), 4 deletions(-) diff --git a/ui/src/pages/chat/chat-responsive.browser.test.ts b/ui/src/pages/chat/chat-responsive.browser.test.ts index 4ca2b9a9c472..2200571a80e7 100644 --- a/ui/src/pages/chat/chat-responsive.browser.test.ts +++ b/ui/src/pages/chat/chat-responsive.browser.test.ts @@ -289,6 +289,80 @@ function completedWorkSpacingHtml() { `; } +function runBlockSpacingHtml() { + return ` +
+
+
+
+
Opening text
+
Detail text
+
Tool row
+
+
+
+
Expanded detail
+
Expanded tool row
+
+
+
+
+ +
+
+
+
+ Assistant +
+ +
+
+
+
+
+
Next turn
+
+
You
+
+
+
+
Persistent identity turn
+
+
+ You +
+ +
+
+
+
+
+
After persistent identity
+
+
Assistant
+
+
+
+
Revealed persistent identity
+
+
+ You +
+ +
+
+
+
+
+
After revealed identity
+
+
Assistant
+
+
+
+ `; +} + function chatFooterActionsHtml() { return `
@@ -1307,6 +1381,63 @@ describeBrowserLayout.concurrent("chat responsive browser layout", () => { } }); + it.each([ + { label: "desktop", width: 1366, hasTouch: false }, + { label: "mobile", width: 430, hasTouch: true }, + ])("keeps transcript turn and run block spacing on $label", async ({ width, hasTouch }) => { + const page = await openBrowserPage(width, 900, { hasTouch, isolated: true }); + try { + await page.setContent( + `${runBlockSpacingHtml()}`, + ); + + const gaps = await page.evaluate(() => { + const rect = (selector: string) => + document.querySelector(selector)!.getBoundingClientRect(); + const gap = (before: string, after: string) => rect(after).top - rect(before).bottom; + return { + intraTurn: gap('[data-run-block="text"]', '[data-run-block="detail"]'), + textToTool: gap('[data-run-block="detail"]', '[data-run-block="tool"]'), + toolToList: gap('[data-run-block="tool"]', '[data-run-block="list"]'), + listToWork: gap('[data-run-block="list"]', '[data-run-block="work"]'), + expandedTextToTool: gap('[data-expanded-row="text"]', '[data-expanded-row="tool"]'), + workedForSeparator: gap( + '[data-run-block="work"] > button', + ".chat-work-group__separator", + ), + turn: gap('[data-run-block="work"]', "[data-next-turn] .chat-bubble"), + persistentTurn: gap( + "[data-persistent-turn] .chat-bubble", + "[data-after-persistent-turn] .chat-bubble", + ), + revealedPersistentTurn: gap( + "[data-revealed-persistent-turn] .chat-bubble", + "[data-after-revealed-turn] .chat-bubble", + ), + simpleToPersistentTurn: gap( + "[data-next-turn] .chat-bubble", + "[data-persistent-turn] .chat-bubble", + ), + }; + }); + + expect(gaps).toEqual({ + intraTurn: 2, + textToTool: 12, + toolToList: 12, + listToWork: 12, + expandedTextToTool: 6, + workedForSeparator: 0, + turn: 50, + persistentTurn: 50, + revealedPersistentTurn: 50, + simpleToPersistentTurn: 50, + }); + } finally { + await closeBrowserPage(page); + } + }); + it("insets only the bundled logo inside the unchanged avatar box", async () => { const page = await openBrowserPage(430, 720); try { diff --git a/ui/src/styles/chat/grouped.css b/ui/src/styles/chat/grouped.css index 4f340b4343fc..a0671b42fa06 100644 --- a/ui/src/styles/chat/grouped.css +++ b/ui/src/styles/chat/grouped.css @@ -3,15 +3,19 @@ ============================================= */ /* Chat Group Layout - default (assistant/other on left). Groups without a - footer keep the shared 26px rhythm directly. Footer-bearing groups split + footer keep the shared turn gap directly. Footer-bearing groups split message content and footer into separate rows so each row keeps the avatar gutter while only the message row controls avatar alignment. */ .chat-group { + --chat-footer-row-offset: 26px; --chat-message-column-max: var(--chat-message-max-width, min(900px, 68%)); + --chat-run-block-gap: 12px; + --chat-touch-row-margin: 14px; + --chat-turn-gap: 50px; display: flex; gap: 10px; align-items: flex-start; - padding-bottom: 26px; + padding-bottom: var(--chat-turn-gap); margin-left: 4px; margin-right: 16px; } @@ -55,7 +59,7 @@ grid-template-rows: auto auto; gap: 2px 10px; justify-content: start; - padding-bottom: 0; + padding-bottom: calc(var(--chat-turn-gap) - var(--chat-footer-row-offset)); } .chat-group.user.chat-group--with-footer { @@ -110,6 +114,21 @@ margin-block-start: var(--chat-message-type-boundary-gap); } +.chat-group + > .chat-group-messages + > :is( + .chat-bubble--tool-shell + .chat-bubble:not(.chat-bubble--tool-shell), + .chat-bubble:not(.chat-bubble--tool-shell) + .chat-bubble--tool-shell, + .chat-bubble + .chat-activity-group, + .chat-activity-group + .chat-bubble, + .chat-work-group + .chat-bubble, + .chat-work-group + .chat-activity-group, + .chat-bubble + .chat-work-group, + .chat-activity-group + .chat-work-group + ) { + margin-block-start: calc(var(--chat-run-block-gap) - 2px); +} + /* User messages align content right */ .chat-group.user .chat-group-messages { align-items: flex-end; @@ -746,11 +765,22 @@ img.chat-avatar.chat-avatar--logo { /* Shared message renderers stay touch-readable by default. Transcript rows opt into one-at-a-time disclosure through their owning thread. */ .chat-group { + --chat-footer-row-offset: 44px; --chat-footer-disclosure-opacity: 1; --chat-footer-disclosure-pointer-events: auto; --chat-footer-detail-position: static; + padding-bottom: calc(var(--chat-turn-gap) - var(--chat-touch-row-margin)); + margin-bottom: var(--chat-touch-row-margin); + } + + .chat-group.chat-group--with-footer:has( + .chat-group-footer:not(.chat-group-footer--persistent-identity) .chat-group-footer-actions + ), + .chat-group.chat-group--with-footer:is(.chat-group--meta-revealed, :focus-within):has( + .chat-group-footer--persistent-identity .chat-group-footer-actions + ) { padding-bottom: 0; - margin-bottom: 14px; + margin-bottom: 0; } .chat-group-footer {