From 0078cd4a58b573d29116e0f3f8238f852cce7035 Mon Sep 17 00:00:00 2001
From: Jesse Merhi <79823012+jesse-merhi@users.noreply.github.com>
Date: Mon, 10 Aug 2026 12:44:46 +1000
Subject: [PATCH] test(security): keep policy approval coverage compact

---
 src/plugins/management-service.test.ts | 60 ++++++--------------------
 1 file changed, 14 insertions(+), 46 deletions(-)

diff --git a/src/plugins/management-service.test.ts b/src/plugins/management-service.test.ts
index 2028652f0d49..4a4fa6b8f8e5 100644
--- a/src/plugins/management-service.test.ts
+++ b/src/plugins/management-service.test.ts
@@ -797,57 +797,25 @@ describe("plugin management service", () => {
         onInstallPolicyWarning: expect.any(Function),
       }),
     );
-  });
-
-  it("consumes Gateway install-policy acknowledgement after one warning", async () => {
+    const installParams = expectDefined(
+      mocks.clawhubInstall.mock.calls[0],
+      "clawhub install call test invariant",
+    )[0] as {
+      onInstallPolicyWarning?: (
+        request: InstallPolicyWarningAcknowledgementRequest,
+      ) => Promise<boolean>;
+    };
+    const acknowledge = installParams.onInstallPolicyWarning;
+    if (!acknowledge) {
+      throw new Error("expected install-policy acknowledgement callback");
+    }
     const warningRequest: InstallPolicyWarningAcknowledgementRequest = {
       targetName: "diffs",
       targetType: "plugin",
       requestMode: "install",
     };
-    const laterWarning = {
-      targetName: "diffs",
-      targetType: "plugin" as const,
-      requestMode: "install" as const,
-      reason: "Dependency tree requires separate review",
-      findings: [
-        {
-          ruleId: "dependency-review",
-          severity: "warn" as const,
-          message: "A dependency triggered policy",
-        },
-      ],
-    };
-    mocks.readConfig.mockResolvedValue(configSnapshot());
-    mockHostedOfficialCatalog([hostedFeedDiffsEntry]);
-    mocks.clawhubInstall.mockImplementation(
-      async (installParams: {
-        onInstallPolicyWarning?: (
-          request: InstallPolicyWarningAcknowledgementRequest,
-        ) => Promise<boolean>;
-      }) => {
-        const acknowledge = installParams.onInstallPolicyWarning;
-        if (!acknowledge) {
-          throw new Error("expected install-policy acknowledgement callback");
-        }
-        expect(await acknowledge(warningRequest)).toBe(true);
-        expect(await acknowledge(warningRequest)).toBe(false);
-        return {
-          ok: false,
-          error: "Install cancelled: the install policy warning was not approved.",
-          code: "security_scan_blocked",
-          installPolicyWarning: laterWarning,
-        };
-      },
-    );
-
-    await expect(
-      installManagedPlugin({
-        request: { source: "official", pluginId: "diffs", acknowledgeInstallPolicyWarning: true },
-        env: {},
-      }),
-    ).rejects.toMatchObject({ installPolicyWarning: laterWarning });
-    expect(mocks.persistInstall).not.toHaveBeenCalled();
+    expect(await acknowledge(warningRequest)).toBe(true);
+    expect(await acknowledge(warningRequest)).toBe(false);
   });
 
   it("removes only the newly installed managed target after persistence conflicts", async () => {