mirror of
https://github.com/open-webui/open-webui.git
synced 2026-08-27 07:54:55 -06:00
699d512e2f
Both session factories run with expire_on_commit=False, so ORM objects keep their attribute values after commit. Every session.refresh issued right after a commit therefore re-SELECTed a row whose values the session already held, including full chat JSON blobs and user settings, purely to overwrite identical data. Fifty such calls existed across the model layer, covering nearly every write path in the app (chat inserts, title updates, pin/archive toggles, user role and settings updates, tool, prompt, function, model, file, tag, feedback, memory, automation and grant writes). All fifty are removed. The only refreshes with an actual job were the two update-then-reload paths in tools and skills, where a Core UPDATE statement bypasses the identity map; those now use session.get(..., populate_existing=True), which guarantees a fresh row in one SELECT whether or not the row was already present in the session (the previous code issued get plus refresh, two SELECTs, on the default configuration). Benchmark (real SQLite DB, per write): | write path | before | after | | --- | --- | --- | | chat title update, ~600 KB chat blob | 2.08 ms | 1.24 ms | | user role update, small row | 1.21 ms | 0.68 ms | On Postgres each removed refresh is additionally a network round trip. The chat-blob case also skips re-parsing the entire JSON document per write. Functionally verified against a fresh database: user insert, role and settings updates, chat insert (including the server-default meta column, which is always provided client-side), title update and pin toggle, tool insert and the Core-update reload path, tag insert and the prompt insert flow that pins version_id after history creation all return correct values and persist correctly.
417 lines
14 KiB
Python
417 lines
14 KiB
Python
import logging
|
|
import time
|
|
from typing import Optional
|
|
from uuid import uuid4
|
|
|
|
from open_webui.internal.db import Base, get_async_db_context
|
|
from pydantic import BaseModel, ConfigDict
|
|
from sqlalchemy import JSON, BigInteger, Boolean, Column, Index, String, Text, cast, delete, func, or_, select, update
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
|
|
####################
|
|
# Automation DB Schema
|
|
####################
|
|
|
|
|
|
class Automation(Base):
|
|
__tablename__ = 'automation'
|
|
|
|
id = Column(Text, primary_key=True)
|
|
user_id = Column(Text, nullable=False)
|
|
name = Column(Text, nullable=False)
|
|
data = Column(JSON, nullable=False) # {prompt, model_id, rrule}
|
|
meta = Column(JSON, nullable=True)
|
|
is_active = Column(Boolean, nullable=False, default=True)
|
|
last_run_at = Column(BigInteger, nullable=True)
|
|
next_run_at = Column(BigInteger, nullable=True)
|
|
|
|
created_at = Column(BigInteger, nullable=False)
|
|
updated_at = Column(BigInteger, nullable=False)
|
|
|
|
__table_args__ = (Index('ix_automation_next_run', 'next_run_at'),)
|
|
|
|
|
|
class AutomationRun(Base):
|
|
__tablename__ = 'automation_run'
|
|
|
|
id = Column(Text, primary_key=True)
|
|
automation_id = Column(Text, nullable=False)
|
|
chat_id = Column(Text, nullable=True)
|
|
status = Column(Text, nullable=False) # success | error
|
|
error = Column(Text, nullable=True)
|
|
created_at = Column(BigInteger, nullable=False)
|
|
|
|
__table_args__ = (
|
|
Index('ix_automation_run_automation_id', 'automation_id'),
|
|
Index('ix_automation_run_aid_created', 'automation_id', 'created_at'),
|
|
)
|
|
|
|
|
|
####################
|
|
# Pydantic Models
|
|
####################
|
|
|
|
|
|
class AutomationTerminalConfig(BaseModel):
|
|
server_id: str
|
|
cwd: Optional[str] = None
|
|
|
|
|
|
class AutomationData(BaseModel):
|
|
prompt: str
|
|
model_id: str
|
|
rrule: str
|
|
terminal: Optional[AutomationTerminalConfig] = None
|
|
|
|
|
|
class AutomationModel(BaseModel):
|
|
model_config = ConfigDict(from_attributes=True)
|
|
|
|
id: str
|
|
user_id: str
|
|
name: str
|
|
data: dict
|
|
meta: Optional[dict] = None
|
|
is_active: bool
|
|
last_run_at: Optional[int] = None
|
|
next_run_at: Optional[int] = None
|
|
|
|
created_at: int
|
|
updated_at: int
|
|
|
|
|
|
class AutomationRunModel(BaseModel):
|
|
model_config = ConfigDict(from_attributes=True)
|
|
|
|
id: str
|
|
automation_id: str
|
|
chat_id: Optional[str] = None
|
|
status: str
|
|
error: Optional[str] = None
|
|
created_at: int
|
|
|
|
|
|
class AutomationForm(BaseModel):
|
|
name: str
|
|
data: AutomationData
|
|
meta: Optional[dict] = None
|
|
is_active: Optional[bool] = True
|
|
|
|
|
|
class AutomationResponse(AutomationModel):
|
|
last_run: Optional[AutomationRunModel] = None
|
|
next_runs: Optional[list[int]] = None
|
|
|
|
|
|
class AutomationListResponse(BaseModel):
|
|
items: list[AutomationModel]
|
|
total: int
|
|
|
|
|
|
####################
|
|
# AutomationTable
|
|
####################
|
|
|
|
|
|
class AutomationTable:
|
|
async def insert(
|
|
self,
|
|
user_id: str,
|
|
form: AutomationForm,
|
|
next_run_at: int,
|
|
db: Optional[AsyncSession] = None,
|
|
) -> AutomationModel:
|
|
async with get_async_db_context(db) as db:
|
|
now = int(time.time_ns())
|
|
row = Automation(
|
|
id=str(uuid4()),
|
|
user_id=user_id,
|
|
name=form.name,
|
|
data=form.data.model_dump(),
|
|
meta=form.meta,
|
|
is_active=form.is_active,
|
|
next_run_at=next_run_at,
|
|
created_at=now,
|
|
updated_at=now,
|
|
)
|
|
db.add(row)
|
|
await db.commit()
|
|
return AutomationModel.model_validate(row)
|
|
|
|
async def count_by_user(self, user_id: str, db: Optional[AsyncSession] = None) -> int:
|
|
async with get_async_db_context(db) as db:
|
|
result = await db.execute(select(func.count()).select_from(Automation).filter_by(user_id=user_id))
|
|
return result.scalar()
|
|
|
|
async def get_by_id(self, id: str, db: Optional[AsyncSession] = None) -> Optional[AutomationModel]:
|
|
async with get_async_db_context(db) as db:
|
|
row = await db.get(Automation, id)
|
|
return AutomationModel.model_validate(row) if row else None
|
|
|
|
async def get_active_by_user(self, user_id: str, db: Optional[AsyncSession] = None) -> list[AutomationModel]:
|
|
"""Get active automations for a user (for calendar RRULE expansion)."""
|
|
async with get_async_db_context(db) as db:
|
|
result = await db.execute(
|
|
select(Automation).filter_by(user_id=user_id, is_active=True).order_by(Automation.created_at.desc())
|
|
)
|
|
return [AutomationModel.model_validate(r) for r in result.scalars().all()]
|
|
|
|
async def search_automations(
|
|
self,
|
|
user_id: str,
|
|
query: Optional[str] = None,
|
|
status: Optional[str] = None,
|
|
skip: int = 0,
|
|
limit: int = 30,
|
|
db: Optional[AsyncSession] = None,
|
|
) -> 'AutomationListResponse':
|
|
async with get_async_db_context(db) as db:
|
|
stmt = select(Automation).filter_by(user_id=user_id)
|
|
|
|
if query:
|
|
search = f'%{query}%'
|
|
# Search in name and prompt inside JSON data
|
|
stmt = stmt.filter(
|
|
or_(
|
|
Automation.name.ilike(search),
|
|
cast(Automation.data, String).ilike(search),
|
|
)
|
|
)
|
|
|
|
if status == 'active':
|
|
stmt = stmt.filter(Automation.is_active == True)
|
|
elif status == 'paused':
|
|
stmt = stmt.filter(Automation.is_active == False)
|
|
|
|
stmt = stmt.order_by(Automation.created_at.desc())
|
|
|
|
# Get total count
|
|
count_result = await db.execute(select(func.count()).select_from(stmt.subquery()))
|
|
total = count_result.scalar()
|
|
|
|
if skip:
|
|
stmt = stmt.offset(skip)
|
|
if limit:
|
|
stmt = stmt.limit(limit)
|
|
|
|
result = await db.execute(stmt)
|
|
rows = result.scalars().all()
|
|
return AutomationListResponse(
|
|
items=[AutomationModel.model_validate(r) for r in rows],
|
|
total=total,
|
|
)
|
|
|
|
async def update_by_id(
|
|
self,
|
|
id: str,
|
|
form: AutomationForm,
|
|
next_run_at: int,
|
|
db: Optional[AsyncSession] = None,
|
|
) -> Optional[AutomationModel]:
|
|
async with get_async_db_context(db) as db:
|
|
row = await db.get(Automation, id)
|
|
if not row:
|
|
return None
|
|
row.name = form.name
|
|
row.data = form.data.model_dump()
|
|
row.meta = form.meta
|
|
if form.is_active is not None:
|
|
row.is_active = form.is_active
|
|
row.next_run_at = next_run_at
|
|
row.updated_at = int(time.time_ns())
|
|
await db.commit()
|
|
return AutomationModel.model_validate(row)
|
|
|
|
async def toggle(
|
|
self,
|
|
id: str,
|
|
next_run_at: Optional[int],
|
|
db: Optional[AsyncSession] = None,
|
|
) -> Optional[AutomationModel]:
|
|
async with get_async_db_context(db) as db:
|
|
row = await db.get(Automation, id)
|
|
if not row:
|
|
return None
|
|
row.is_active = not row.is_active
|
|
row.next_run_at = next_run_at if row.is_active else None
|
|
row.updated_at = int(time.time_ns())
|
|
await db.commit()
|
|
return AutomationModel.model_validate(row)
|
|
|
|
async def delete(self, id: str, db: Optional[AsyncSession] = None) -> bool:
|
|
async with get_async_db_context(db) as db:
|
|
row = await db.get(Automation, id)
|
|
if not row:
|
|
return False
|
|
await db.delete(row)
|
|
await db.commit()
|
|
return True
|
|
|
|
async def claim_due(self, now_ns: int, limit: int = 10, db: Optional[AsyncSession] = None) -> list[AutomationModel]:
|
|
"""
|
|
Atomically claim due automations for execution.
|
|
|
|
Advances next_run_at immediately so the row can never be
|
|
double-claimed. On PostgreSQL, uses FOR UPDATE SKIP LOCKED
|
|
for zero-contention distributed work claiming.
|
|
"""
|
|
async with get_async_db_context(db) as db:
|
|
stmt = (
|
|
select(Automation)
|
|
.where(
|
|
Automation.is_active == True,
|
|
Automation.next_run_at <= now_ns,
|
|
)
|
|
.order_by(Automation.next_run_at)
|
|
.limit(limit)
|
|
)
|
|
|
|
if db.bind.dialect.name == 'postgresql':
|
|
stmt = stmt.with_for_update(skip_locked=True)
|
|
|
|
result = await db.execute(stmt)
|
|
rows = result.scalars().all()
|
|
|
|
from open_webui.utils.automations import next_run_ns
|
|
|
|
# Batch-fetch user timezones so rescheduling respects each
|
|
# user's local timezone instead of falling back to server time.
|
|
user_ids = list({row.user_id for row in rows})
|
|
timezone_by_user_id: dict[str, Optional[str]] = {}
|
|
if user_ids:
|
|
from open_webui.models.users import User
|
|
|
|
tz_result = await db.execute(select(User.id, User.timezone).where(User.id.in_(user_ids)))
|
|
timezone_by_user_id = {uid: tz for uid, tz in tz_result.all()}
|
|
|
|
for row in rows:
|
|
row.last_run_at = now_ns
|
|
row.next_run_at = next_run_ns(row.data.get('rrule', ''), tz=timezone_by_user_id.get(row.user_id))
|
|
|
|
await db.commit()
|
|
|
|
return [AutomationModel.model_validate(r) for r in rows]
|
|
|
|
|
|
####################
|
|
# AutomationRunTable
|
|
####################
|
|
|
|
|
|
class AutomationRunTable:
|
|
async def insert(
|
|
self,
|
|
automation_id: str,
|
|
status: str,
|
|
chat_id: Optional[str] = None,
|
|
error: Optional[str] = None,
|
|
db: Optional[AsyncSession] = None,
|
|
) -> AutomationRunModel:
|
|
async with get_async_db_context(db) as db:
|
|
row = AutomationRun(
|
|
id=str(uuid4()),
|
|
automation_id=automation_id,
|
|
chat_id=chat_id,
|
|
status=status,
|
|
error=error,
|
|
created_at=int(time.time_ns()),
|
|
)
|
|
db.add(row)
|
|
await db.commit()
|
|
return AutomationRunModel.model_validate(row)
|
|
|
|
async def get_latest(self, automation_id: str, db: Optional[AsyncSession] = None) -> Optional[AutomationRunModel]:
|
|
async with get_async_db_context(db) as db:
|
|
result = await db.execute(
|
|
select(AutomationRun)
|
|
.filter_by(automation_id=automation_id)
|
|
.order_by(AutomationRun.created_at.desc())
|
|
.limit(1)
|
|
)
|
|
row = result.scalars().first()
|
|
return AutomationRunModel.model_validate(row) if row else None
|
|
|
|
async def get_latest_batch(
|
|
self, automation_ids: list[str], db: Optional[AsyncSession] = None
|
|
) -> dict[str, AutomationRunModel]:
|
|
"""Fetch the latest run for each automation in a single query."""
|
|
if not automation_ids:
|
|
return {}
|
|
async with get_async_db_context(db) as db:
|
|
# Subquery: max created_at per automation_id
|
|
subq = (
|
|
select(
|
|
AutomationRun.automation_id,
|
|
func.max(AutomationRun.created_at).label('max_created'),
|
|
)
|
|
.filter(AutomationRun.automation_id.in_(automation_ids))
|
|
.group_by(AutomationRun.automation_id)
|
|
.subquery()
|
|
)
|
|
result = await db.execute(
|
|
select(AutomationRun).join(
|
|
subq,
|
|
(AutomationRun.automation_id == subq.c.automation_id)
|
|
& (AutomationRun.created_at == subq.c.max_created),
|
|
)
|
|
)
|
|
rows = result.scalars().all()
|
|
return {row.automation_id: AutomationRunModel.model_validate(row) for row in rows}
|
|
|
|
async def get_by_automation(
|
|
self,
|
|
automation_id: str,
|
|
skip: int = 0,
|
|
limit: int = 50,
|
|
db: Optional[AsyncSession] = None,
|
|
) -> list[AutomationRunModel]:
|
|
async with get_async_db_context(db) as db:
|
|
result = await db.execute(
|
|
select(AutomationRun)
|
|
.filter_by(automation_id=automation_id)
|
|
.order_by(AutomationRun.created_at.desc())
|
|
.offset(skip)
|
|
.limit(limit)
|
|
)
|
|
rows = result.scalars().all()
|
|
return [AutomationRunModel.model_validate(r) for r in rows]
|
|
|
|
async def delete_by_automation(self, automation_id: str, db: Optional[AsyncSession] = None) -> int:
|
|
async with get_async_db_context(db) as db:
|
|
result = await db.execute(delete(AutomationRun).filter_by(automation_id=automation_id))
|
|
await db.commit()
|
|
return result.rowcount
|
|
|
|
async def get_runs_by_user_range(
|
|
self,
|
|
user_id: str,
|
|
start_ns: int,
|
|
end_ns: int,
|
|
limit: int = 500,
|
|
db: Optional[AsyncSession] = None,
|
|
) -> list[tuple['AutomationRunModel', 'AutomationModel']]:
|
|
"""Get runs within a date range for a user, joined with parent automation."""
|
|
async with get_async_db_context(db) as db:
|
|
result = await db.execute(
|
|
select(AutomationRun, Automation)
|
|
.join(Automation, Automation.id == AutomationRun.automation_id)
|
|
.filter(
|
|
Automation.user_id == user_id,
|
|
AutomationRun.created_at >= start_ns,
|
|
AutomationRun.created_at < end_ns,
|
|
)
|
|
.order_by(AutomationRun.created_at.desc())
|
|
.limit(limit)
|
|
)
|
|
return [
|
|
(AutomationRunModel.model_validate(run), AutomationModel.model_validate(auto))
|
|
for run, auto in result.all()
|
|
]
|
|
|
|
|
|
Automations = AutomationTable()
|
|
AutomationRuns = AutomationRunTable()
|