Commit Graph

11 Commits

Author SHA1 Message Date
Classic298 504e724fde fix: detect bare pipe alternation as regex in grep_knowledge_files (#26795)
is_regex_pattern only recognized the BRE-escaped form \| and not a bare |,
so a pattern like "Jornak|Silverlake|Orissa" was treated as one literal
string (including the pipe characters) and silently returned no matches.
This contradicted the tool docstring, which explicitly advertises
"error|warn" as an auto-detected regex example, and misled models into
concluding the searched terms were absent from the file.

Checking for a bare | also covers the escaped form, since \| contains |,
and normalize_regex already converts escaped pipes before compilation.
Literal patterns without regex metacharacters are unaffected.

Fixes #26781
2026-07-23 23:33:35 -04:00
Timothy Jaeryang Baek 8d2fee5d45 refac 2026-07-23 22:35:54 -04:00
Timothy Jaeryang Baek e18e249d5d refac 2026-07-23 03:39:30 -04:00
Timothy Jaeryang Baek 40b655e99e refac 2026-06-29 11:44:21 -05:00
Timothy Jaeryang Baek 6fce92aa12 chore: format 2026-06-01 13:56:55 -07:00
Timothy Jaeryang Baek cc16e06c32 refac 2026-05-14 03:10:48 +09:00
Timothy Jaeryang Baek 74f95a9b0d refac 2026-05-14 02:08:35 +09:00
Timothy Jaeryang Baek 4e78b355ef refac 2026-05-14 02:00:23 +09:00
Timothy Jaeryang Baek 2f642754ac refac 2026-05-13 16:00:56 +09:00
Timothy Jaeryang Baek ecec86dd32 refac 2026-05-13 15:55:21 +09:00
Timothy Jaeryang Baek 5b125c24d4 feat: kb_exec 2026-05-13 15:41:30 +09:00