From ef197de0d7bcbae8b83baf6a421e3cea5d318eb4 Mon Sep 17 00:00:00 2001
From: G30 <50341825+silentoplayz@users.noreply.github.com>
Date: Sun, 26 Jul 2026 17:26:34 -0400
Subject: [PATCH] fix: open settings deep links on client-side navigation and
 open Add Terminal settings directly (#27552)

---
 src/lib/components/chat/MessageInput/TerminalMenu.svelte | 3 +--
 src/routes/(app)/+layout.svelte                          | 8 +++++++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/lib/components/chat/MessageInput/TerminalMenu.svelte b/src/lib/components/chat/MessageInput/TerminalMenu.svelte
index 3fee20df28..c74ab4208d 100644
--- a/src/lib/components/chat/MessageInput/TerminalMenu.svelte
+++ b/src/lib/components/chat/MessageInput/TerminalMenu.svelte
@@ -1,6 +1,5 @@
 <script lang="ts">
 	import { getContext } from 'svelte';
-	import { goto } from '$app/navigation';
 
 	import { settings, showSettings, terminalServers, selectedTerminalId, user } from '$lib/stores';
 	import { getToolServersData } from '$lib/apis';
@@ -193,7 +192,7 @@
 									class="p-0.5 rounded-md text-gray-400 hover:text-gray-600 dark:text-gray-500 dark:hover:text-gray-300 transition"
 									on:click|stopPropagation={() => {
 										show = false;
-										goto('/admin/settings/integrations');
+										showSettings.set('admin:integrations');
 									}}
 								>
 									<svg
diff --git a/src/routes/(app)/+layout.svelte b/src/routes/(app)/+layout.svelte
index 62cebf0c96..6bec3dde60 100644
--- a/src/routes/(app)/+layout.svelte
+++ b/src/routes/(app)/+layout.svelte
@@ -199,6 +199,9 @@
 	const openSettingsFromUrl = async () => {
 		const requestedSettings = $page.url.searchParams.get('settings');
 		if (!requestedSettings) {
+			// Param handled and stripped; allow the same deep link to be
+			// handled again later in this session.
+			handledSettingsUrl = '';
 			return;
 		}
 
@@ -382,7 +385,10 @@
 		loaded = true;
 	});
 
-	$: if (loaded) {
+	// `$page.url` must be referenced here: `$:` only tracks variables used in
+	// the statement itself, and reads inside openSettingsFromUrl don't count —
+	// without it, client-side navigations to `?settings=...` are never handled.
+	$: if (loaded && $page.url) {
 		void openSettingsFromUrl();
 	}