From 085d11eef22a57cf7b465b2fd03194b05fa5ca92 Mon Sep 17 00:00:00 2001 From: G30 <50341825+silentoplayz@users.noreply.github.com> Date: Mon, 27 Jul 2026 00:44:51 -0400 Subject: [PATCH] chore: drop redundant background repaints so surfaces inherit their parent (#27576) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * chore: drop redundant background repaints so surfaces inherit their parent Four spots repaint the exact color their parent surface already provides (bg-white / dark:bg-gray-900 rows inside same-colored pages and modals, and the selectClass dark repaint inside the connection modals — the sibling input const is already fully transparent). Visually identical in stock light and dark; removing them lets instance theming show through instead of leaving opaque boxes: - .tiptap tr (app.css) — table rows in notes/editors - Edit User Group Users tab body rows (common Modal surface) - AddToolServerModal + AddTerminalServerModal selectClass dark repaint The matching repaints inside the ModelUsage/UserUsage components are not part of this change — those files were dead code and were removed entirely in #27574. * chore: catch remaining redundant surface repaints missed in the first pass Same rule as the previous commit — every one of these repaints the exact color its parent surface already provides, so removal is stock-identical in light and dark while letting instance theming show through: - Analytics Dashboard's inline Model Usage / User Activity row markup (the Analytics tab renders these tables from Dashboard.svelte itself; the unreferenced ModelUsage/UserUsage component files were removed in #27574) - Evaluations Feedbacks + Leaderboard body rows (settings modal surface) - admin UserList body rows (app page surface) - chat markdown tables (MarkdownTokens): thead and body rows — unlike the tiptap header (gray-850 contrast, untouched), this thead painted the page's own color - CitationsModal source rows (common Modal surface) - AddConnectionModal selectClass dark repaint — third copy of the same const already fixed in AddToolServerModal / AddTerminalServerModal --- src/app.css | 2 +- src/lib/components/AddConnectionModal.svelte | 2 +- src/lib/components/AddTerminalServerModal.svelte | 2 +- src/lib/components/AddToolServerModal.svelte | 2 +- src/lib/components/admin/Analytics/Dashboard.svelte | 4 ++-- src/lib/components/admin/Evaluations/Feedbacks.svelte | 2 +- src/lib/components/admin/Evaluations/Leaderboard.svelte | 2 +- src/lib/components/admin/Users/Groups/Users.svelte | 2 +- src/lib/components/admin/Users/UserList.svelte | 2 +- .../chat/Messages/Citations/CitationsModal.svelte | 2 +- .../components/chat/Messages/Markdown/MarkdownTokens.svelte | 6 ++---- 11 files changed, 13 insertions(+), 15 deletions(-) diff --git a/src/app.css b/src/app.css index e9e3eef35e..1d9c74770e 100644 --- a/src/app.css +++ b/src/app.css @@ -685,7 +685,7 @@ html.high-contrast.dark .ProseMirror p.is-editor-empty:first-child::before { } .tiptap tr { - @apply bg-white dark:bg-gray-900 dark:border-gray-850 text-xs; + @apply dark:border-gray-850 text-xs; } .tippy-box[data-theme~='transparent'] { diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index 3a3549a40c..16616fc247 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -63,7 +63,7 @@ const inputClass = 'bg-transparent outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; const selectClass = - 'dark:bg-gray-900 bg-transparent pr-5 outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; + 'bg-transparent pr-5 outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; const parsePassthroughParams = (value: string) => value diff --git a/src/lib/components/AddTerminalServerModal.svelte b/src/lib/components/AddTerminalServerModal.svelte index 9e8a003a8e..0cf622b86f 100644 --- a/src/lib/components/AddTerminalServerModal.svelte +++ b/src/lib/components/AddTerminalServerModal.svelte @@ -62,7 +62,7 @@ const inputClass = 'bg-transparent outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; const selectClass = - 'dark:bg-gray-900 bg-transparent pr-5 outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; + 'bg-transparent pr-5 outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; const stringifyJson = (value: object | null | undefined) => { return JSON.stringify(value && Object.keys(value).length ? value : {}, null, 2); diff --git a/src/lib/components/AddToolServerModal.svelte b/src/lib/components/AddToolServerModal.svelte index 27efb8bcec..4bb310140e 100644 --- a/src/lib/components/AddToolServerModal.svelte +++ b/src/lib/components/AddToolServerModal.svelte @@ -72,7 +72,7 @@ const inputClass = 'bg-transparent outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; const selectClass = - 'dark:bg-gray-900 bg-transparent pr-5 outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; + 'bg-transparent pr-5 outline-hidden placeholder:text-gray-300 dark:placeholder:text-gray-700'; const registerOAuthClientHandler = async () => { if (url === '') { diff --git a/src/lib/components/admin/Analytics/Dashboard.svelte b/src/lib/components/admin/Analytics/Dashboard.svelte index 3f2c78b426..b1cc9e3a5e 100644 --- a/src/lib/components/admin/Analytics/Dashboard.svelte +++ b/src/lib/components/admin/Analytics/Dashboard.svelte @@ -468,7 +468,7 @@ {#each sortedModels as model, idx (model.model_id)} { selectedModel = { id: model.model_id, name: model.name }; showModelModal = true; @@ -581,7 +581,7 @@ {#each sortedUsers as user, idx (user.user_id)} - + {idx + 1}
diff --git a/src/lib/components/admin/Evaluations/Feedbacks.svelte b/src/lib/components/admin/Evaluations/Feedbacks.svelte index aa7ebda9a8..ade792ccb8 100644 --- a/src/lib/components/admin/Evaluations/Feedbacks.svelte +++ b/src/lib/components/admin/Evaluations/Feedbacks.svelte @@ -418,7 +418,7 @@ {#each items as feedback (feedback.id)} openFeedbackModal(feedback)} > diff --git a/src/lib/components/admin/Evaluations/Leaderboard.svelte b/src/lib/components/admin/Evaluations/Leaderboard.svelte index 3feff897ba..07180e4685 100644 --- a/src/lib/components/admin/Evaluations/Leaderboard.svelte +++ b/src/lib/components/admin/Evaluations/Leaderboard.svelte @@ -201,7 +201,7 @@ {#each sortedModels as model, idx (model.id)} openModal(model)} > diff --git a/src/lib/components/admin/Users/Groups/Users.svelte b/src/lib/components/admin/Users/Groups/Users.svelte index ca60647265..2c2aeab667 100644 --- a/src/lib/components/admin/Users/Groups/Users.svelte +++ b/src/lib/components/admin/Users/Groups/Users.svelte @@ -234,7 +234,7 @@ {#each users as user, userIdx (user?.id ?? userIdx)} - +
{#each users as user (user.id)} - +
diff --git a/src/lib/components/chat/Messages/Citations/CitationsModal.svelte b/src/lib/components/chat/Messages/Citations/CitationsModal.svelte index b43e5cd4ef..beafa0e36f 100644 --- a/src/lib/components/chat/Messages/Citations/CitationsModal.svelte +++ b/src/lib/components/chat/Messages/Citations/CitationsModal.svelte @@ -60,7 +60,7 @@ {#each citations as citation, idx}