mirror of
https://github.com/rbalsleyMSFT/FFU.git
synced 2026-06-14 02:09:35 -06:00
Adds SystemId support for HP driver management
Enhances HP driver handling to properly track and display SystemId alongside ProductName throughout the driver workflow. Parses SystemId from HP PlatformList.xml and creates unique entries per ProductName/SystemId combination to avoid conflicts when multiple models share the same product name but different system identifiers. Updates driver lookup and metadata preservation to include SystemId, MachineType, and ProductName fields across download tasks and result processing, ensuring this information persists through JSON import/export operations. Improves display name generation to show "ProductName (SystemId)" format for HP models when both values are available, providing clearer model identification in the UI and configuration files. Standardizes driver metadata handling by replacing simple Make lookups with comprehensive driver metadata lookups that preserve all relevant fields for Dell, HP, and Lenovo vendors.
This commit is contained in:
rbalsleyMSFT
@@ -66,30 +66,45 @@ function Get-HPDriversModelList {
|
||||
$settings.Async = $false # Ensure synchronous reading
|
||||
|
||||
$reader = [System.Xml.XmlReader]::Create($platformListXml, $settings)
|
||||
$uniqueModels = [System.Collections.Generic.HashSet[string]]::new([System.StringComparer]::OrdinalIgnoreCase)
|
||||
$uniqueEntries = [System.Collections.Generic.HashSet[string]]::new([System.StringComparer]::OrdinalIgnoreCase)
|
||||
|
||||
while ($reader.Read()) {
|
||||
if ($reader.NodeType -eq [System.Xml.XmlNodeType]::Element -and $reader.Name -eq 'Platform') {
|
||||
# Read the inner content of the Platform node
|
||||
$platformReader = $reader.ReadSubtree()
|
||||
$platformNames = [System.Collections.Generic.List[string]]::new()
|
||||
$platformSystemId = $null
|
||||
|
||||
while ($platformReader.Read()) {
|
||||
if ($platformReader.NodeType -eq [System.Xml.XmlNodeType]::Element -and $platformReader.Name -eq 'ProductName') {
|
||||
$modelName = $platformReader.ReadElementContentAsString()
|
||||
if (-not [string]::IsNullOrWhiteSpace($modelName) -and $uniqueModels.Add($modelName)) {
|
||||
# Add to list only if it's a new unique model
|
||||
$modelList.Add([PSCustomObject]@{
|
||||
Make = $Make
|
||||
Model = $modelName
|
||||
})
|
||||
if ($platformReader.NodeType -eq [System.Xml.XmlNodeType]::Element) {
|
||||
if ($platformReader.Name -eq 'ProductName') {
|
||||
$modelName = $platformReader.ReadElementContentAsString()
|
||||
if (-not [string]::IsNullOrWhiteSpace($modelName)) {
|
||||
$platformNames.Add($modelName.Trim())
|
||||
}
|
||||
}
|
||||
elseif ($platformReader.Name -eq 'SystemID') {
|
||||
$platformSystemId = $platformReader.ReadElementContentAsString().Trim()
|
||||
}
|
||||
}
|
||||
}
|
||||
$platformReader.Close()
|
||||
|
||||
foreach ($name in $platformNames) {
|
||||
$systemIdKey = if (-not [string]::IsNullOrWhiteSpace($platformSystemId)) { $platformSystemId } else { '' }
|
||||
$compositeKey = "$name|$systemIdKey"
|
||||
if ($uniqueEntries.Add($compositeKey)) {
|
||||
$modelList.Add([PSCustomObject]@{
|
||||
Make = $Make
|
||||
Model = $name
|
||||
SystemId = $platformSystemId
|
||||
})
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
$reader.Close()
|
||||
|
||||
WriteLog "Successfully parsed $($modelList.Count) unique HP models from PlatformList.xml."
|
||||
WriteLog "Successfully parsed $($modelList.Count) HP model and SystemID combinations from PlatformList.xml."
|
||||
|
||||
}
|
||||
catch {
|
||||
@@ -97,7 +112,7 @@ function Get-HPDriversModelList {
|
||||
}
|
||||
|
||||
# Sort the list alphabetically by Model name before returning
|
||||
return $modelList | Sort-Object -Property Model
|
||||
return $modelList | Sort-Object -Property Model, SystemId
|
||||
}
|
||||
# Function to download and extract drivers for a specific HP model (Designed for ForEach-Object -Parallel)
|
||||
function Save-HPDriversTask {
|
||||
@@ -123,19 +138,34 @@ function Save-HPDriversTask {
|
||||
[bool]$PreserveSourceOnCompress = $false
|
||||
)
|
||||
|
||||
$modelName = $DriverItemData.Model
|
||||
$displayModelName = if (-not [string]::IsNullOrWhiteSpace($DriverItemData.Model)) { $DriverItemData.Model } else { $DriverItemData.Id }
|
||||
$make = $DriverItemData.Make # Should be 'HP'
|
||||
$identifier = $modelName # Unique identifier for progress updates
|
||||
$sanitizedModelName = ConvertTo-SafeName -Name $modelName
|
||||
if ($sanitizedModelName -ne $modelName) { WriteLog "Sanitized model name: '$modelName' -> '$sanitizedModelName'" }
|
||||
$productName = if ($DriverItemData.PSObject.Properties['ProductName'] -and -not [string]::IsNullOrWhiteSpace($DriverItemData.ProductName)) { $DriverItemData.ProductName } else { ConvertTo-DriverBaseName -ModelString $displayModelName }
|
||||
if ([string]::IsNullOrWhiteSpace($productName)) { $productName = $displayModelName }
|
||||
$systemIdentifier = if ($DriverItemData.PSObject.Properties['SystemId'] -and -not [string]::IsNullOrWhiteSpace($DriverItemData.SystemId)) { $DriverItemData.SystemId } else { $null }
|
||||
if ([string]::IsNullOrWhiteSpace($displayModelName)) {
|
||||
$displayModelName = if ([string]::IsNullOrWhiteSpace($systemIdentifier)) { $productName } else { Get-DriverDisplayName -BaseName $productName -Identifier $systemIdentifier }
|
||||
}
|
||||
$identifier = $displayModelName # Unique identifier for progress updates
|
||||
$sanitizedModelName = ConvertTo-SafeName -Name $identifier
|
||||
if ($sanitizedModelName -ne $identifier) { WriteLog "Sanitized model name: '$identifier' -> '$sanitizedModelName'" }
|
||||
$hpDriversBaseFolder = Join-Path -Path $DriversFolder -ChildPath $make # Changed variable name for clarity
|
||||
$platformListXml = Join-Path -Path $hpDriversBaseFolder -ChildPath "PlatformList.xml"
|
||||
$modelSpecificFolder = Join-Path -Path $hpDriversBaseFolder -ChildPath $sanitizedModelName # Sanitize model name for folder path
|
||||
$driverRelativePath = Join-Path -Path $make -ChildPath $sanitizedModelName # Relative path for the driver folder
|
||||
$finalStatus = "" # Initialize final status
|
||||
$successState = $true # Assume success unless an operation fails
|
||||
|
||||
if (-not (Test-Path -Path $DriversFolder -PathType Container)) {
|
||||
WriteLog "Creating Drivers folder: $DriversFolder"
|
||||
New-Item -Path $DriversFolder -ItemType Directory -Force | Out-Null
|
||||
}
|
||||
if (-not (Test-Path -Path $hpDriversBaseFolder -PathType Container)) {
|
||||
WriteLog "Creating HP drivers folder: $hpDriversBaseFolder"
|
||||
New-Item -Path $hpDriversBaseFolder -ItemType Directory -Force | Out-Null
|
||||
}
|
||||
|
||||
if ($null -ne $ProgressQueue) { Invoke-ProgressUpdate -ProgressQueue $ProgressQueue -Identifier $identifier -Status "Checking HP drivers for $modelName..." }
|
||||
if ($null -ne $ProgressQueue) { Invoke-ProgressUpdate -ProgressQueue $ProgressQueue -Identifier $identifier -Status "Checking HP drivers for $displayModelName..." }
|
||||
|
||||
try {
|
||||
# Check for existing drivers
|
||||
@@ -190,13 +220,23 @@ function Save-HPDriversTask {
|
||||
}
|
||||
}
|
||||
|
||||
# Parse PlatformList.xml to find SystemID and OSReleaseID for the specific model
|
||||
WriteLog "Parsing $platformListXml for model '$modelName' details..."
|
||||
# Parse the PlatformList.xml to find the SystemID based on the ProductName
|
||||
WriteLog "Parsing $platformListXml for model '$displayModelName' (SystemID: $systemIdentifier) details..."
|
||||
[xml]$platformListContent = Get-Content -Path $platformListXml -Raw -Encoding UTF8 -ErrorAction Stop
|
||||
$platformNode = $platformListContent.ImagePal.Platform | Where-Object { $_.ProductName.'#text' -match "^$([regex]::Escape($modelName))$" } | Select-Object -First 1
|
||||
$platformNode = $null
|
||||
if (-not [string]::IsNullOrWhiteSpace($systemIdentifier)) {
|
||||
$platformNode = $platformListContent.ImagePal.Platform | Where-Object { $_.SystemID -eq $systemIdentifier } | Select-Object -First 1
|
||||
if ($null -eq $platformNode) {
|
||||
WriteLog "SystemID '$systemIdentifier' not found in PlatformList.xml. Falling back to ProductName search."
|
||||
}
|
||||
}
|
||||
if ($null -eq $platformNode) {
|
||||
$searchName = if (-not [string]::IsNullOrWhiteSpace($productName)) { $productName } else { $displayModelName }
|
||||
$platformNode = $platformListContent.ImagePal.Platform | Where-Object { $_.ProductName.'#text' -match "^$([regex]::Escape($searchName))$" } | Select-Object -First 1
|
||||
}
|
||||
|
||||
if ($null -eq $platformNode) {
|
||||
throw "Model '$modelName' not found in PlatformList.xml."
|
||||
throw "Model '$displayModelName' (SystemID: $systemIdentifier) not found in PlatformList.xml."
|
||||
}
|
||||
|
||||
$systemID = $platformNode.SystemID
|
||||
@@ -289,11 +329,11 @@ function Save-HPDriversTask {
|
||||
}
|
||||
$availableVersionsString = ($allAvailableVersions | Select-Object -Unique) -join ', '
|
||||
if ([string]::IsNullOrWhiteSpace($availableVersionsString)) { $availableVersionsString = "None" }
|
||||
throw "Could not find any suitable OS driver pack for model '$modelName' matching requested or fallback versions (Win$($WindowsRelease) $WindowsVersion). Available: $availableVersionsString"
|
||||
throw "Could not find any suitable OS driver pack for model '$displayModelName' matching requested or fallback versions (Win$($WindowsRelease) $WindowsVersion). Available: $availableVersionsString"
|
||||
}
|
||||
|
||||
$osReleaseIdFileName = $selectedOSNode.OSReleaseIdFileName -replace 'H', 'h'
|
||||
WriteLog "Using SystemID: $systemID and OS Info: Win$($selectedOSRelease) ($($selectedOSVersion)) for '$modelName'"
|
||||
WriteLog "Using SystemID: $systemID and OS Info: Win$($selectedOSRelease) ($($selectedOSVersion)) for '$displayModelName'"
|
||||
$archSuffix = $WindowsArch -replace "^x", ""
|
||||
$modelRelease = "$($systemID)_$($archSuffix)_$($selectedOSRelease).0.$($selectedOSVersion.ToLower())"
|
||||
$driverCabUrl = "https://hpia.hpcloud.hp.com/ref/$systemID/$modelRelease.cab"
|
||||
@@ -312,7 +352,7 @@ function Save-HPDriversTask {
|
||||
$updates = $driverXmlContent.ImagePal.Solutions.UpdateInfo | Where-Object { $_.Category -match '^Driver' }
|
||||
$totalDrivers = ($updates | Measure-Object).Count
|
||||
$downloadedCount = 0
|
||||
WriteLog "Found $totalDrivers driver updates for $modelName."
|
||||
WriteLog "Found $totalDrivers driver updates for $displayModelName."
|
||||
if ($null -ne $ProgressQueue) { Invoke-ProgressUpdate -ProgressQueue $ProgressQueue -Identifier $identifier -Status "Found $totalDrivers drivers. Downloading..." }
|
||||
|
||||
if (-not (Test-Path -Path $modelSpecificFolder)) {
|
||||
@@ -359,7 +399,7 @@ function Save-HPDriversTask {
|
||||
}
|
||||
|
||||
Remove-Item -Path $driverCabFile, $driverXmlFile -Force -ErrorAction SilentlyContinue
|
||||
WriteLog "Cleaned up driver cab and xml files for $modelName"
|
||||
WriteLog "Cleaned up driver cab and xml files for $displayModelName"
|
||||
|
||||
$finalStatus = "Completed"
|
||||
if ($CompressToWim) {
|
||||
@@ -380,7 +420,7 @@ function Save-HPDriversTask {
|
||||
$successState = $true
|
||||
}
|
||||
catch {
|
||||
$errorMessage = "Error saving HP drivers for $($modelName): $($_.Exception.Message)"
|
||||
$errorMessage = "Error saving HP drivers for $($displayModelName): $($_.Exception.Message)"
|
||||
WriteLog $errorMessage
|
||||
$finalStatus = "Error: $($_.Exception.Message.Split([Environment]::NewLine)[0])"
|
||||
$successState = $false
|
||||
|
||||
Reference in New Issue
Block a user