From dbb98ba4febdabf906051209526291c9d780b1a3 Mon Sep 17 00:00:00 2001 From: rbalsleyMSFT <53497092+rbalsleyMSFT@users.noreply.github.com> Date: Tue, 17 Jun 2025 18:31:56 -0700 Subject: [PATCH] Refactor: Improve code clarity and remove unused variable Renames the event handler parameter from `$sender` to `$eventSource` for better readability. Removes an unused variable in the parallel processing function to clean up the code. --- .../FFU.Common/FFU.Common.Parallel.psm1 | 1 - .../FFUUI.Core.WindowsSettings.psm1 | 24 +++++++++---------- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/FFUDevelopment/FFU.Common/FFU.Common.Parallel.psm1 b/FFUDevelopment/FFU.Common/FFU.Common.Parallel.psm1 index 2342a31..3a3a1e6 100644 --- a/FFUDevelopment/FFU.Common/FFU.Common.Parallel.psm1 +++ b/FFUDevelopment/FFU.Common/FFU.Common.Parallel.psm1 @@ -34,7 +34,6 @@ function Invoke-ParallelProcessing { } $resultsCollection = [System.Collections.Generic.List[object]]::new() $jobs = @() - $results = @() # Store results from jobs $totalItems = $ItemsToProcess.Count $processedCount = 0 diff --git a/FFUDevelopment/FFUUI.Core/FFUUI.Core.WindowsSettings.psm1 b/FFUDevelopment/FFUUI.Core/FFUUI.Core.WindowsSettings.psm1 index 14e6da4..45cf046 100644 --- a/FFUDevelopment/FFUUI.Core/FFUUI.Core.WindowsSettings.psm1 +++ b/FFUDevelopment/FFUUI.Core/FFUUI.Core.WindowsSettings.psm1 @@ -540,19 +540,19 @@ function BuildFeaturesGrid { $chk.Content = $featureName $chk.Margin = "5" $chk.Add_Checked({ - param($sender, $e) - $window = [System.Windows.Window]::GetWindow($sender) - if ($null -ne $window) { - UpdateOptionalFeaturesString -State $window.Tag - } - }) + param($eventSource, $e) + $window = [System.Windows.Window]::GetWindow($eventSource) + if ($null -ne $window) { + UpdateOptionalFeaturesString -State $window.Tag + } + }) $chk.Add_Unchecked({ - param($sender, $e) - $window = [System.Windows.Window]::GetWindow($sender) - if ($null -ne $window) { - UpdateOptionalFeaturesString -State $window.Tag - } - }) + param($eventSource, $e) + $window = [System.Windows.Window]::GetWindow($eventSource) + if ($null -ne $window) { + UpdateOptionalFeaturesString -State $window.Tag + } + }) $State.Controls.featureCheckBoxes[$featureName] = $chk # Track the checkbox