From d6689888b24ea49b403ebbe5eafbf69cdde85917 Mon Sep 17 00:00:00 2001
From: rbalsleyMSFT <53497092+rbalsleyMSFT@users.noreply.github.com>
Date: Sat, 28 Jun 2025 00:57:38 -0700
Subject: [PATCH] Refactor: Remove redundant Success property assignment

Removes the logic that adds a `Success` property to the returned object when an existing driver package is found.

This property is handled by the calling function, making this assignment unnecessary and simplifying the driver-saving task functions.
---
 FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Dell.psm1      | 5 -----
 FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.HP.psm1        | 5 -----
 FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Lenovo.psm1    | 5 -----
 FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Microsoft.psm1 | 5 -----
 4 files changed, 20 deletions(-)

diff --git a/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Dell.psm1 b/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Dell.psm1
index 3d67561..6be2f64 100644
--- a/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Dell.psm1
+++ b/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Dell.psm1
@@ -208,11 +208,6 @@ function Save-DellDriversTask {
                 if ($null -ne $ProgressQueue) { Invoke-ProgressUpdate -ProgressQueue $ProgressQueue -Identifier $modelName -Status $existingDriver.Status }
             }
 
-            # Ensure the Success property exists on the object being returned.
-            if (-not $existingDriver.PSObject.Properties.Name -contains 'Success') {
-                $existingDriver | Add-Member -MemberType NoteProperty -Name 'Success' -Value $true
-            }
-
             return $existingDriver
         }
 
diff --git a/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.HP.psm1 b/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.HP.psm1
index 5ba4bd3..8640a4b 100644
--- a/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.HP.psm1
+++ b/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.HP.psm1
@@ -152,11 +152,6 @@ function Save-HPDriversTask {
                 if ($null -ne $ProgressQueue) { Invoke-ProgressUpdate -ProgressQueue $ProgressQueue -Identifier $identifier -Status $existingDriver.Status }
             }
 
-            # Ensure the Success property exists on the object being returned.
-            if (-not $existingDriver.PSObject.Properties.Name -contains 'Success') {
-                $existingDriver | Add-Member -MemberType NoteProperty -Name 'Success' -Value $true
-            }
-
             return $existingDriver
         }
 
diff --git a/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Lenovo.psm1 b/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Lenovo.psm1
index c81a3bf..3924faf 100644
--- a/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Lenovo.psm1
+++ b/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Lenovo.psm1
@@ -126,11 +126,6 @@ function Save-LenovoDriversTask {
                 if ($null -ne $ProgressQueue) { Invoke-ProgressUpdate -ProgressQueue $ProgressQueue -Identifier $identifier -Status $existingDriver.Status }
             }
 
-            # Ensure the Success property exists on the object being returned.
-            if (-not $existingDriver.PSObject.Properties.Name -contains 'Success') {
-                $existingDriver | Add-Member -MemberType NoteProperty -Name 'Success' -Value $true
-            }
-
             return $existingDriver
         }
 
diff --git a/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Microsoft.psm1 b/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Microsoft.psm1
index 6c29263..86edf20 100644
--- a/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Microsoft.psm1
+++ b/FFUDevelopment/FFUUI.Core/FFUUI.Core.Drivers.Microsoft.psm1
@@ -132,11 +132,6 @@ function Save-MicrosoftDriversTask {
                 if ($null -ne $ProgressQueue) { Invoke-ProgressUpdate -ProgressQueue $ProgressQueue -Identifier $modelName -Status $existingDriver.Status }
             }
 
-            # Ensure the Success property exists on the object being returned.
-            if (-not $existingDriver.PSObject.Properties.Name -contains 'Success') {
-                $existingDriver | Add-Member -MemberType NoteProperty -Name 'Success' -Value $true
-            }
-
             return $existingDriver
         }